bgpd: make as-path-loop-detection conform to the framework #15553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdumontet6WIND
force-pushed
the
as_path_loop
branch
2 times, most recently
from
266f048 to
e82475c
Compare
currently: when as-path-loop-detection is set on a peer-group. members of the peer-group are not using that functionnality. analysis: the as-path-loop-detection, is not using the peer's flags related framework. fix: use the peer's flag framework for as-path-loop-detection. Signed-off-by: Francois Dumontet <[email protected]>
fdumontet6WIND
force-pushed
the
as_path_loop
branch
3 times, most recently
from
d1b1431 to
a294cc3
Compare
ton31337
reviewed
Mar 14, 2024
tests/topotests/bgp_sender_as_path_loop_detection/test_bgp_sender-as-path-loop-detection.py
Show resolved
Hide resolved
add a tests of setting as-path-loop-detection through peer-group Signed-off-by: Francois Dumontet <[email protected]>
fdumontet6WIND
force-pushed
the
as_path_loop
branch
from
a294cc3 to
260bdaf
Compare
|
ci:rerun |
|
failure not related to bgp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently:
when as-path-loop-detection is set on a peer-group.
members of the peer-group are not using that functionnality.
analysis:
the as-path-loop-detection, is not using the peer's flags
related framework.
fix:
use the peer's flag framework for as-path-loop-detection.
Signed-off-by: Francois Dumontet [email protected]